11.1.0PRO - some little errors and suggestions

zmx
Topic Author
Posts: 14
3 months 6 days ago #4543 by zmx
about the new quote feature.
the quote icon should not be visible if the user is not allowed to post (e.g. banned or guest/not allowed)
- in the actual code it throws a JS error because of the missing textarea

also the thumbsup function throws a JS error (in joomla message.js ? ) when user is not allowed to post
- not sure if it is a good idea to keep this function for guests or banned.

suggestion:
for the quote text sometimes it is not consense like to kill smileys, so before switching to JS innerText
(which cuts out all Tags) it could be helpfull to recode the smileycode to keep it in the text, it just needs
one line and a small addition:
1. message = message.replaceAll('alt=":','> :') img tag will be closed instead of "alt" and the code stays outside the img tag
2. add a replaceAll to div.innerText.trim() + .replaceAll('">',' ') to cut out the rest of the img code

- ok, this will only work for smileys with leading ":" code

Please Log in or Create an account to join the conversation.

Lodder
Lodder's Avatar
Posts: 1248
3 months 6 days ago #4544 by Lodder
Hi,

I've taken a note of the issues you raised and will fix them in the next update.
Thank you for reporting them.

Regards,
Lodder

Please Log in or Create an account to join the conversation.

zmx
Topic Author
Posts: 14
3 months 5 days ago #4545 by zmx
another one (half error?)

why have you set the condition for moving the image-modal div to the end
only be done if the bbCodeForm is shown (so if the user can post).

the modal image is rendered also for non-posting (guests), but the
"inside" modal container will be overlayed by the modal-backdrop,
so no closing works (somtimes esc) and the image is covered grey

I think you have had some reasons?

Please Log in or Create an account to join the conversation.

Lodder
Lodder's Avatar
Posts: 1248
3 months 4 days ago #4546 by Lodder
For the life of me, I can't actually remember, but it might have been a mistake.
Looking at the GIT history, I added that block of code 7 years ago.

Are you saying I should remove the "bbcodeForm" from the condition?

Please Log in or Create an account to join the conversation.

zmx
Topic Author
Posts: 14
3 months 3 days ago #4547 by zmx
yes, the "bbcodeForm" should be removed, as it gives problems/errors in this way.
If you want to disable modal image for not-posting-allowed user
the modal klick is better disabled by removing the target=#jj-image-modal, e.g. target="#"

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum